Zoom buttons broken in kicker

[Allan Sandfeld Jensen]

On Tuesday 27 August 2002 01:33, Waldo Bastian wrote:
> On Monday 26 August 2002 04:07 pm, Waldo Bastian wrote:
> > I strongly suspect that your commit of panelbasebutton.cpp revision 1.19
> > has broken icon zooming in kicker.
> >
> > In the CVS version you now occasionaly get an "unknown" zoomed icon
> > instead of the correct zoomed icon.
> >
> > Since this commit seems to be related to a new feature that isn't going
> > to be part of KDE 3.1 anyway I suggest that you revert your commit.
>
It is in the feature list, but it disables if zooming is enabled. It is also 
disabled by default since we dont have animated versions of the icons in 
kicker yet. 

> The part that breaks it is actually in revision 1.18:
> @@ -600,6 +624,8 @@ void PanelButtonBase::loadTiles()
>  void PanelButtonBase::drawButton(QPainter *p)
>  {
>      setBackground();
> +    if (calculateIconSizes())
> +        loadIcons();
>
>      QPixmap bg(size());
>      QPainter pbg;
>
You're right. The two lines has been removed. Seems some old debug-code 
escaped into the wild and made trouble. 
OTOH it wouldnt be a bug (just useless code) if it wasnt for problems in the 
specialized buttons. 

Thanks
`Allan