Short hostnames in URLs
l.lunak at sh.cvut.cz
Thu Aug 8 09:38:04 BST 2002
Dne čt 8. srpen 2002 03:43 Dawit A. napsal(a):
> On Wednesday 07 August 2002 12:45, Lubos Lunak wrote:
> > Dne st 7. srpen 2002 16:45 Simon Hausmann napsal(a):
> > [snip]
[snipped uninterestings thing about QDns, as patch #2 doesn't use it]
> > I wouldn't. Attached is try #2. Unless there are some more technical
> > details to discuss, could now somebody with dial-up check if the timeout
> > value doesn't cause some problems?
> I am completely against this patch or any other patch that does any type of
> lookup at this level. I do understand your issue and I can also understand
> why you do not like the compromise solution I mentioned to you eventhough
> it is much flexiable in terms of what protocol you can attach to it, but
> your patch forces the DNS lookup on everyone like the other browsers do
> which I personally do not care for.
> Having said that I have one really easy way of resolving this issue for
> you. Take this very patch and write your own URIFilter plugin. All you
> have to do is inherit from KURIFilterPlugin and re-implement filterURI and
> create a desktop for your plugin using the one in the shorturi filter
> plugin. It is extremely simple to do this and once installed it will be
> used by any application that that makes use of KURIFilter (currently
> konqueror and minicli). And then you can add it in kdeaddons or whereever
> and viola, no need to try and convience people about why you need it and no
> need to reapply patches when KDE changes etc...
So instead of adding it to kshorturifilter, I should write a new plugin for
kdeaddons? How does that change anything, besides being more work, and
explicitly saying it's mine code and not yours? Nothing will change for the
And I still fail to see the problem with having the lookup there. The DNS
lookup is limited to 0,5s , which is nothing considering that right now the
filter turns it into Google search, so the user would have to wait anyway.
Morever, the DNS lookup is done only rarely, only if the command doesn't
contain whitespaces, dots, colons, it's not a valid URL nor a valid command,
which basically rules out almost everything except for things that would end
up as a Google search anyway. Let me stress this once again: Unless I missed
something, the lookup will be done only if it would otherwise become a Google
search (but not for all Google searches).
Caching: I think this will just make it more complicated and is not worth is.
I don't find it a good idea to cache e.g. 1000+ hosts, and these short
hostames should be used only by people in LANs anyway.
If you're still against applying this patch to kshorturifilter, I'll do as
you said and put a new filter in kdeaddons, but given the things above, I
consider it rather silly.
llunak at suse.cz ; l.lunak at kde.org
More information about the kde-core-devel