[PATCH] Re: Improving the Layout of KControl modules (was: Re Gnome ....)

[Martijn Klingens]

(whoooops... apologies to tackat, I sent a private reply to him twice, instead 
of to the list :/ )

On Wednesday 24 April 2002 17:24, you wrote:
> Wow, looks *much* cleaner to me and much more simple.
> Is it just a matter of changing the .ui-file to make it work like this or
> is some additional coding needed? Will you do/commit it :-) ?

There was: it was a coded GUI, which I converted to .ui files. See attached 
patch and .ui file.

I integrated Thomas' remark as well (a simple label on top and the detailed 
user agent in the advanced part), but I'm not sure if I like it. The top part 
is much cleaner now, but the dialog as whole looks a bit more complex and 
cluttered to me again. Any comments on that? Torsten? Thomas?

Also, Dawit had some #if 0-ed GUI stuff in the files, which obviously doesn't 
translate well to .ui files. Therefore I removed this completely for now. 
Before committing I think Dawit will like to thoroughly review that part and 
help me add it in a sane way...

And a bug: changing the checkboxes doesn't update the user agent string 
preview. No idea if I introduced that, but it looks like it already existed.

Apart from that, it was easier than I thought to convert coded widgets to .ui 
files, though an awful lot of boring work to copy-paste variable names and 
what's this help...

Please review and comment, especially Torsten, Thomas and Dawit.

Martijn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: useragent.diff
Type: text/x-diff
Size: 16501 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020426/ea52417b/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: useragentdlg_base.ui.gz
Type: application/x-gzip
Size: 2858 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20020426/ea52417b/attachment.bin>