ioslave terminating mechanism

[aleXXX]

On Wednesday 17 April 2002 20:41, Waldo Bastian wrote:
> On Wednesday 17 April 2002 08:11 am, Malte Starostik wrote:
> > Not sure, but I suspect that this code in slavebase.cpp is rather
> > dangerous:
> >
> > void genericsig_handler(int sigNumber)
> > {
> >    signal(sigNumber,SIG_IGN);
> >    //I don't think we can have the same problem here as in the sigsegv
> > handler kdDebug()<<"kioslave : exiting due to signal "<<sigNumber<<endl;
> > //call the dtor of the slave and exit
> >    if (globalSlave!=0)
> >       globalSlave->~SlaveBase();
> >    exit(2);
> > };
>
> Yes, I think the whole concept of calling a destructor there is misguided.
> If you need to clean anything up in your io-slave when you get killed you
> should install a signal handler yourself.
>
> Cheers,
> Waldo

Actually I always expected that the ioslave dtors are called when an ioslave 
exits, until I found out that this is not the case and added the dtor calls. 
Ioslaves feel more like plugins, you think you're writing only a lib and a 
lib shouldn't exit its process (i.e. not handle signals).
This fixes major problems e.g. with the smbro ioslave.
I guess other ioslave authors expect the same, why else should they have 
written dtors for their ioslaves ?

If I understand the code correctly, it changes the behaviour in this way, 
that a signal leads to gen_handler(), which jumps into the if() {} in 
dispatchLoop(), which does the same as the former signal handler did.
Why does it behave differently ?
Maybe just removing the kdDebug() would already help ?

Bye
Alex