Bug#40835: toolbar icons work only as "icons only"

[Waldo Bastian]

On Sunday 14 April 2002 11:14 am, Cristian Tibirna wrote:
> (NOTE: this is not an answer, but an RFC directed to kde-core-devel)
>
> This bug report is not really related to kcmstyle, as the module itself
> works very well.
>
> But try to go in katerc, kmailrc etc and remove the [*Toolbar*]
> configuration sections. The first time the respective app starts after
> this, it will obey the kcmstyle configuration. But it immediately saves
> this configuration to its rc file, which makes that if user changes the
> configuration in kcmstyle, the respective application won't obey anymore
> (unless the config sections for the toolbars are removed again).
>
> Now, I believe there is a development guideline that says that default
> configuration items aren't saved to the rc file. So, I ask: why don't the
> toolbar ui classes obey this guideline? I mean, is there a special reason?

Are we talking about the KConfig files or about XML files?

I don't think there is a guideline that says that default configuration items 
aren't saved to config files. Although it certainly would make sense. In KDE 
2.x we always saved default values to config files afaik, in KDE 3.x we no 
longer save default values iff the default value is defined in another config 
file. But there are some limitations to this, e.g. if the default is defined 
in foorc then these defaults will not be taken into account when barrc is 
written. I'm not sure what the exact behaviour is when the defaults are 
listed in $KDEHOME/share/config/kdeglobals and a $KDEHOME/share/config/foorc 
file is written. It could very well be that such defaults are not taken into 
account either. It's the difference between "system defaults" (for all users) 
and "user defaults" (for all applications of a certain user).

> Second, no matter what the answer is to the above question, I believe that
> the local toolbar settings (available through contextual menu of toolbars)
> should include an item "use general settings" or "use default", which will
> effectively remove the config group from apps' rc file. Do you agree with
> me adding this?

Yes. Note that "Icon Size" already has an "Default" entry.

Cheers,
Waldo
-- 
bastian at kde.org  |   SuSE Labs KDE Developer  |  bastian at suse.com