[PATCH] ksystemtray.cpp

[Klas Kalass]

[Please feel free to forward this to kde-core-devel.]

Am Samstag, 13. April 2002 09:22 schrieb Simon Hausmann:
> On Fri, Apr 12, 2002 at 11:50:53PM +0200, Martijn Klingens wrote:
> > On Friday 12 April 2002 23:37, Waldo Bastian wrote:
> > > I think such a change can potentially cause havoc in existing code,
> > > yes. I am not familar enough with ksystemtray or it's usage to say much
> > > more about it.
> >
> > Me neither. All I know is that relying on closing the main window to quit
> > an app is a bit weird, since that wouldn't abort apps with background
> > jobs. Or that might have been exactly the purpose, to just close the
> > window and don't really quit until such a job is finished. Argl... so
> > much for someone who *knows* this code...
>
> I think it is a bad idea to call qApp->quit() from a library class,
> because it unconditionally aborts the application, completely
> disobeying KApplication's reference counting (which exists for the
> very reason of preventing leaving the event loop in case there are
> still background jobs like KIO tranfers) .
>
> What was wrong with closeAllWindows() ?
Please see my reply to Martijns' original post on kde-devel (I do not have 
write acces to kde-core-devel).
In short: An application with a ksystray icon is not supposed to exit when all 
windows are closed (according to the styleguide), so closeAllWindows() should 
not quit the application and thus is of no use here.

Cheers.
Klas