[kde-community] What is a GitHub pull request exactly?

Martin Graesslin mgraesslin at kde.org
Sat Sep 19 16:22:17 UTC 2015


On Saturday, September 19, 2015 6:11:21 PM CEST you wrote:
> On Saturday, September 19, 2015 05:47:38 PM Martin Graesslin wrote:
> > On Saturday, September 19, 2015 5:32:33 PM CEST Kevin Krammer wrote:
> > > If the problem is somewhere in (a), where is it?
> > 
> > I'm afraid of code review happening through the pull request instead of
> > our
> > infrastructure. To me github pull requests are not just the "here's the
> > patch", but also the code review.
> 
> Can we agree to have pull requests enabled in case the code review keeps
> happening on reviewboard? I think everybody could agree on that point...

And how do we do that? Can we enforce this technically or will that be 
weakened over the time the same way as we just turned the mirror into "let's 
accept pull requests"?

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-community/attachments/20150919/f0f15a00/attachment.sig>


More information about the kde-community mailing list