[kde-community] Official KDE mirror on github

Jaroslaw Staniek staniek at kde.org
Sat Sep 19 08:05:54 UTC 2015


On Saturday, 19 September 2015, Martin Graesslin <mgraesslin at kde.org> wrote:
> On Friday, September 18, 2015 5:29:01 PM CEST Albert Vaca wrote:
>> From my experience, I was already mirroring KDE Connect in Github and
I've
>> received valuable patches there. That's a big enough reason for me to
want
>> Github's pull requests (and to spend 15 minutes learning how to use
them),
>> but I understand not everybody wants to learn a new and non-free tool.
>
> I'm subscribed to kde-connects review requests for reviewboard. How am I
as an
> interested developer able to follow the code review for github pull
requests
> if I don't want to use them?
>
> Basically by the decision to opt-in for pull requests you force the
complete
> team to follow them. Otherwise not-reviewed code gets in.

What I meant is that review is handled in a free tool. See I asked about
deprecating review board not once to have on tool for the task -phab, for a
reason.
Github is just like Gmail in this workflow, even less because in my book
you can't keep using it for regular contributions -this is a knowledge you
get after the first *motivating* success of approved patches.
Even at single subproject level fellow contributors don't see a downside,
only a chance for more patches.


>
> We really need to think in the big picture of what means this to KDE. We
> shouldn't go the "selfish" road and think of your own project. By allowing
> github pull-requests we are pushing out the contributors who don't want
to use
> it. You make it impossible for those contributors to comment on review
> requests, thus you have split the development.
>

See above, these are not the discussed bits.

> This is scary. Please don't think "selfish". Let people create the pull
> request and answer it with:
> "Sorry we do not support git hub pull request. To submit code please use
> reviewboard.kde.org. Here's how you do it..."


And can I do better than that 'slap in the face', I am free to do that.




>
> The point is we want to get to the people on github. That's why we mirror.
> It's not about getting pull requests. We want the people! They already
spent
> the effort to create the patch, they will spent the additional time to
get to
> reviewboard of phabricator in future. I have so often got patches on
bugzilla
> and it never was a problem to tell them "please use reviewboard for the
patch
> submission as the UI is more streamlined for code review". We always got
the
> patch into reviewboard. The aim of the people is not to use pull
requests, the
> aim is to submit their patch!
>

This is you talking to them in person. Quite better thing than automatic
closing.

> Cheers
> Martin
>

-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-community/attachments/20150919/864a2a1c/attachment.html>


More information about the kde-community mailing list