D28355: Introduce function ecm_install_configured_file

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Mon Mar 30 19:37:58 BST 2020


kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in ECMConfiguredInstall.cmake:62
> These strings (besides the last obviously) should get added with whitespace suffix, to handle the case where multiple are added, no? Not yet got to test/run things, just guessing by reading code.

Actually, _configure_args could be a list  (starting with empty, not "") and one would do list(APPEND). And cmake would then properly resolve that var when used with configure_file I would expect (to be tested).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20200330/6305e77a/attachment.html>


More information about the Kde-buildsystem mailing list