D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names
    Aleix Pol Gonzalez 
    noreply at phabricator.kde.org
       
    Sun Jan 19 23:25:13 GMT 2020
    
    
  
apol accepted this revision.
apol added a comment.
  Looks good to me, bonus points if you provide a better commit message explaining what it does and how you tested it.
REPOSITORY
  R240 Extra CMake Modules
BRANCH
  sc_appicon
REVISION DETAIL
  https://phabricator.kde.org/D26751
To: patrickelectric, tcanabrava, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20200119/14bfd34f/attachment-0001.html>
    
    
More information about the Kde-buildsystem
mailing list