D26670: ki18n_wrap_ui: error when file doesn't exist

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Jan 14 19:45:29 GMT 2020


kossebau added inline comments.

INLINE COMMENTS

> KF5I18nMacros.cmake.in:52
>     foreach (_current_FILE ${ARGN})
> -
> +      if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/${_current_FILE})
> +         message(SEND_ERROR

This assumes a relative path given. It might make sense to also deal with absolute path, and only append CMAKE_CURRENT_LIST_DIR if not absolute, then check for existance?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26670

To: davidre, #framework_syntax_highlighting, #localization, #build_system
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20200114/4663a55a/attachment.html>


More information about the Kde-buildsystem mailing list