D24568: Provide clang-format target with a KDE Frameworks style file

Christoph Cullmann noreply at phabricator.kde.org
Sun Feb 9 11:45:46 GMT 2020


cullmann added a comment.


  In D24568#563653 <https://phabricator.kde.org/D24568#563653>, @cullmann wrote:
  
  > For the lambda issue, I think we can add:
  >
  >   # keep lambda formatting multi-line if not empty
  >   AllowShortLambdasOnASingleLine: Empty
  >
  >
  > see https://clang.llvm.org/docs/ClangFormatStyleOptions.html
  >
  > That fixes for me the issue with the collapsed lambda.
  >
  > For the comments, as said, we can remove
  >
  >   AlignTrailingComments: true
  >
  >
  > For the generic issue of stuff folded in one line, one can play with the ColumnLimit, but as said, that will still arbitrarily pack stuff as long as it fits the limit.
  >
  > Kai, could you try the two changes (for lambda and comments) by just temporarily changing that in the .clang-format file locally and rerunning make clang-format?
  
  
  Hi, would it be ok to add this two improvements?
  
  Beside that, has somebody tried the formatting again?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure, broulik, davidedmundson
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20200209/b3e0ad9b/attachment.html>


More information about the Kde-buildsystem mailing list