D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Feb 6 14:40:35 GMT 2020
kossebau added a comment.
@mlaurent Thanks for review :)
Do you happen to know any more complex usages of ecm_qt_declare_logging_category and/or manual category definitions which can and should be checked for how these new methods would work out?
I have not really researched bigger parts of KDE code for if the currently proposed method calls will be sufficient to cover all use cases. So far it's mainly based on KDevelop, kcoreaddons, kservice & sonnet use-cases.
So far it was mainly: @broulik complained on irc, a day later I accidentally found another approach to the target-based hack we had in kdevelop, changed kdevelop cmake code, then pulled out the core logic and turned into this patch, after trying to port kcoreaddons, kservice & sonnet :)
Thus also hesitating to merge on first positive review, as I am not sure myself yet, still thinking of this as prototype to get feedback on.
REPOSITORY
R240 Extra CMake Modules
BRANCH
addautomaticcategoriesgeneration
REVISION DETAIL
https://phabricator.kde.org/D27150
To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20200206/7cfe1490/attachment.html>
More information about the Kde-buildsystem
mailing list