D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ECMQtDeclareLoggingCategory.cmake:76
> +#       FILE <filename>
> +#       DESTINATION <install_path>
> +#       [SORT]

Why the need for explicit DESTINATION argument, where almost all use-cases will use ${KDE_INSTALL_LOGGINGCATEGORIESDIR}?
Because ECMQtDeclareLoggingCategory is part of modules, not kde-modules, so KDEInstallDirs cannot be used.

One could think about having a wrapper module in kde-modules. But such a wrapper script would be nice for more things actually, given all the repeated boilerpplate across e.g. all the KF repos :)

So asking for explicit mention of the installation destination is consistent.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20200204/5a6136ea/attachment.html>