D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Sep 11 16:58:17 BST 2019


kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in ECMGenerateExportHeader.cmake:87
> I'm having trouble parsing the "only" in this sentence.
> 
> `deprecated API only`... that seems redundant, it's only API that gets deprecated :-)
> 
> Maybe you mean "to disable only at build time"?
> Or "declaration-only code" ?
> 
> and it's always about build time... the choice is between building the library and building the users of the library, isn't it? It's all "build time" of someone...

I tried to reword things a bit, also changed all other places talking about build time to be explicit.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190911/117acc91/attachment-0001.html>


More information about the Kde-buildsystem mailing list