D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Sep 5 00:05:34 BST 2019
kossebau created this revision.
kossebau added reviewers: Frameworks, Build System, vkrause.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
The initial API asked to have custom C++ code to be parsed as string
arguments. As any ";" in such strings would be treated as list separators,
the initial API as workaround required to encode those in the passed
code text with "@SEMICOLON@".
As alternative variant the approach from the GENERATE_EXPORT_HEADER()
macro and its CUSTOM_CONTENT_FROM_VARIABLE is now used, where instead
the name of the variable is passed, from which then the full code could
be fetched and directly used.
As API user one no longer can pass code snippets directly inline as
argument, but no longer needs to use the awkward @SEMICOLON at .
As ECMAddQtDesignerPlugin is not yet part of a released version,
the API can be still changed.
REPOSITORY
R240 Extra CMake Modules
BRANCH
createqtdesignerpluginpasscodebyvarname
REVISION DETAIL
https://phabricator.kde.org/D23725
AFFECTED FILES
modules/ECMAddQtDesignerPlugin.cmake
To: kossebau, #frameworks, #build_system, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190904/bdd2761d/attachment.html>
More information about the Kde-buildsystem
mailing list