D24568: Provide clang-format target with a KDE Frameworks style file

Christoph Cullmann noreply at phabricator.kde.org
Sat Oct 19 16:42:00 BST 2019


cullmann added inline comments.

INLINE COMMENTS

> zzag wrote in clang-format.cmake:75
> I've been always wondering how one should break long ternary operators when writing KF code. There are several ways to do it
> 
> (a) w/o breaking (BreakBeforeTernaryOperators: false)
> 
>   const FooBar *foobar = someStupidCondition() ?
>       someSuperDuperBeatifulFunctionWithLongName() :
>       anotherSuperDuperBeatifuuuulFunctionWithLongName();
> 
> (b) w/ breaking (BreakBeforeTernaryOperators: true)
> 
>   const FooBar *foobar = someStupidCondition()
>       ? someSuperDuperBeatifulFunctionWithLongName()
>       : anotherSuperDuperBeatifuuuulFunctionWithLongName();
> 
> According to the _clang-format file from the qt5 super repo, Qt fellas prefer (b) to break before ternary operators.
> 
> Do we really want to not break before ternary opeartors?

I have no strong opinion on that, we can remove that or keep it.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20191019/857bed5a/attachment.html>


More information about the Kde-buildsystem mailing list