D24568: Provide clang-format target with a common KDE style file

David Edmundson noreply at phabricator.kde.org
Sat Oct 12 11:49:59 BST 2019


davidedmundson added inline comments.

INLINE COMMENTS

> KDEClangFormat.cmake:48
> +if(KDE_CLANG_FORMAT_EXECUTABLE)
> +    configure_file(${CMAKE_CURRENT_LIST_DIR}/clang-format.cmake ${CMAKE_CURRENT_SOURCE_DIR}/.clang-format @ONLY)
> +endif()

it's a bit weird to put new files in the source directory when running cmake.

Copying when running the target clang-format would probably be ok as there you're already doing an explicit operation which changes the source.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20191012/8898c526/attachment.html>


More information about the Kde-buildsystem mailing list