D24568: Provide clang-format target with a KDE Frameworks style file

Christoph Cullmann noreply at phabricator.kde.org
Sun Nov 17 11:48:06 GMT 2019


cullmann added a comment.


  In D24568#563092 <https://phabricator.kde.org/D24568#563092>, @davidedmundson wrote:
  
  > As an update on this from the Plasma POV.
  >
  > I added the macro to every repo and told every dev to do a final test before we commit the formatted results.
  >
  > I had some feedback and the result was that we can't proceed with in the current state [1].
  >
  > What's noteworthy is we were generally ok with the results from the first file we prepared in T11214 <https://phabricator.kde.org/T11214>, so potentially we just need some settings tweaked. 
  >  I'll try and break that down into future diffs.
  >
  > 1.https://mail.kde.org/pipermail/plasma-devel/2019-November/106186.html
  
  
  For the comment alignment stuff, that is easy, we can just remove
  
  AlignTrailingComments: true
  
  For the other general "moving between different lines" stuff, I don't see any solution for this.
  
  You can arbitrary change the ColumnLimit, but as far as I know, it will just arbitrarily pack stuff together, like in the if conditions, if you have not e.g. comments in-between.
  
  But perhaps somebody else knows a proper switch for that.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20191117/ce2b0bee/attachment.html>


More information about the Kde-buildsystem mailing list