D21313: Create specific directory for kdebugsettings categories file

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri May 24 15:44:04 BST 2019

kossebau added inline comments.


> KDEInstallDirs.cmake:131
>  #     autostart files (``CONFDIR/autostart``) [``AUTOSTART_INSTALL_DIR``]
> +#     kdebugsettings categories files directory (``DATAROOTDIR/debug-categories5``) Since 5.59.0

Might `LOGGINGCATEGORIESDIR` or perhaps short `LOGCATDIR`  not be a better name, for one more following the naming pattern of Qt, but also more clearly pointing out what this is about? Debug categories could mean a lot, while this here is about logging only.

> KDEInstallDirs.cmake:132
> +#     kdebugsettings categories files directory (``DATAROOTDIR/debug-categories5``) Since 5.59.0
>  #

given this is adding a dir in the shared naming area, could this perhaps be more specific named, unless the plan is to make this a general-purpose dir shared among all kind of applications & toolkits?
For now this data is only for one program, kdebugsettings, so IMHO that should be reflected here.

  R240 Extra CMake Modules


To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190524/1c7f5461/attachment.html>

More information about the Kde-buildsystem mailing list