D16894: [ECM] use a macro to add compiler flags conditionally

[René J.V. Bertin]

rjvbb added a comment.


  >   So according to you, this line is useful ? from my point of view, it's needless and just looks like a syntax error.
  
  Yes, it shows which compiler is being queried and for what. The line is going to be there anyway because CMake's Check*CompilerFlag macros don't have a QUIET option.
  
  We can discuss the exact dynamic variable name but since Cmake will not query the compiler twice for the same return variable the template should contain both the compiler ID and the flag being tested in order to cover all possible uses.
  I've considered trying to reset the cached result variable but we probably don't want to lose the benefits of that caching.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190131/36a6b9e6/attachment.html>