D16894: [ECM] use a macro to add compiler flags conditionally

[René J.V. Bertin]

rjvbb added a comment.


  > Forget that. The syntax is confusing, please remove this HASFLAG
  
  That I'm not going to do. The goal is to both to have useful feedback like below, and to avoid caching issues that would cause on the first query to be performed (if you were to use a single result variable):
  
    -- Performing Test Clang++_ACCEPTS-Wvla
    ``
    
    I decided against the idea of using a single macro name with a language parameter very early during development. It adds a parameter to each call or extra code to the macro to implement a default value, it can lead to errors that can remain undetected, and it deviates from the usual CMake syntax.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190131/370b79bc/attachment.html>