D16894: [ECM] use a macro to add compiler flags conditionally

David Faure noreply at phabricator.kde.org
Wed Jan 30 11:34:10 GMT 2019


dfaure added a comment.


  In D16894#402209 <https://phabricator.kde.org/D16894#402209>, @rjvbb wrote:
  
  > >   In that sentence, one can read "if supported" for the macro name, ...
  >
  > That was my idea too, and the reason the macro ends in "_if_supported".
  
  
  Right, but I was saying all this because I think IF_SUPPORTED (the keyword in the arguments) should be SUPPORTED_IF.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190130/1e4198e1/attachment.html>


More information about the Kde-buildsystem mailing list