D18943: Add Fontconfig find modudle

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindFontconfig.cmake:56
> +# in the FIND_PATH() and FIND_LIBRARY() calls
> +find_package(PkgConfig)
> +pkg_check_modules(PC_FONTCONFIG QUIET fontconfig)

QUIET here as well

> apol wrote in FindFontconfig.cmake:57
> If you use IMPORTED_TARGET you can skip most stuff below. i.e.
> `pkg_check_modules(Flatpak IMPORTED_TARGET flatpak>=0.11.8)`
> 
> In fact, I'd argue it's just easier to have pkg_check_modules called upstream rather than having an intermediary in ECM or so. 
> It's what I did in Discover at least:
> https://phabricator.kde.org/source/discover/browse/master/CMakeLists.txt$36

ECM requires CMake 2.8.12. 'IMPORTED_TARGET' is not available in this version.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: kossebau, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190216/317aaec7/attachment-0001.html>