D18947: Bring FindUDev.cmake up to ECM standards

Albert Astals Cid noreply at phabricator.kde.org
Sat Feb 16 09:57:57 GMT 2019


aacid added inline comments.

INLINE COMMENTS

> FindUDev.cmake:75
> +        IMPORTED_LOCATION "${UDev_LIBRARIES}"
> +        INTERFACE_INCLUDE_DIRECTORIES "${UDev_INCLUDE_DIRS}"
> +    )

Do we need a 
INTERFACE_COMPILER_DEFINITIONS "${UDev_DEFINITIONS}"
just in case that udev adds some definitions at some point?

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18947

To: vkrause, #build_system, cgiboudeaux, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190216/07e1ed2e/attachment-0001.html>


More information about the Kde-buildsystem mailing list