D18943: Add Fontconfig find modudle

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Feb 12 14:21:47 GMT 2019


kossebau added a comment.


  Could the indentation perhaps be turned to be 4 spaces while copying it here? While https://community.kde.org/Policies/CMake_Coding_Style#Indentation allows the choice of 2,3, or 4 spaces, using 4 is more in line with the indentation used in C++ sources, so IMHO more expected to read.
  
  Please also add a `docs/find-module/FindFontconfig.rst` with a line linking this file:
  
    .. ecm-module:: ../../find-modules/FindFontconfig.cmake
  
  so the documentation generation will cover also this new module.
  
  When it comes to pkgconfig no idea myself, but please update https://community.kde.org/Policies/CMake_Coding_Style#.28Not.29_Using_pkg-config if you find those rules do no longer apply.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: kossebau, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190212/c1dfef43/attachment.html>


More information about the Kde-buildsystem mailing list