D18943: Add Fontconfig find modudle

Volker Krause noreply at phabricator.kde.org
Tue Feb 12 10:47:05 GMT 2019


vkrause added inline comments.

INLINE COMMENTS

> apol wrote in FindFontconfig.cmake:57
> If you use IMPORTED_TARGET you can skip most stuff below. i.e.
> `pkg_check_modules(Flatpak IMPORTED_TARGET flatpak>=0.11.8)`
> 
> In fact, I'd argue it's just easier to have pkg_check_modules called upstream rather than having an intermediary in ECM or so. 
> It's what I did in Discover at least:
> https://phabricator.kde.org/source/discover/browse/master/CMakeLists.txt$36

Does that mean we can rely on pkgconfig? So far I got the impression we have to treat that as optional in ECM code?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause
Cc: apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190212/4c646beb/attachment.html>


More information about the Kde-buildsystem mailing list