D24641: Collect more information from version control systems

[Thomas Fischer]

thomasfischer updated this revision to Diff 71145.
thomasfischer marked 4 inline comments as done.
thomasfischer edited the summary of this revision.
thomasfischer edited the test plan for this revision.
thomasfischer added a comment.


  I tried to address the most recent comments:
  
  - Added documentation at the file's beginning in comments. Not sure how to test if syntax, though. Spelling, grammar, and wording should be checked as well (not a native speaker).
  - Functions ``ecm_source_version_control_probe_branch`` and ``ecm_source_version_control_probe_revision`` now have an 'outvar'. When invoking either of the functions, a variable name needs to be passed where the result is stored inside.
  - Locating the Git binary has been refactored into a 'private' function ``_ecm_source_version_control_detect_git``.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24641?vs=69225&id=71145

REVISION DETAIL
  https://phabricator.kde.org/D24641

AFFECTED FILES
  modules/ECMSourceVersionControl.cmake

To: thomasfischer, sitter, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20191209/9010db37/attachment.html>