D22958: Add initial Android support to ecm_add_app_icon
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Aug 6 00:43:07 BST 2019
apol added a comment.
The patch makes sense. +1
INLINE COMMENTS
> ECMAddAppIcon.cmake:154
> + set(ext "${CMAKE_MATCH_4}")
> + if(NOT ${icon_type} STREQUAL ".svg" OR NOT ${icon_type} STREQUAL ".svgz")
> + message(AUTHOR_WARNING "${icon_full} is not a SVG file - ignoring")
this if could go up to where we're checking the icon name in an elseif up at line 146.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D22958
To: hein, #frameworks, mart, leinir, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190805/a7bcf422/attachment.html>
More information about the Kde-buildsystem
mailing list