D22958: Add initial Android support to ecm_add_app_icon
Eike Hein
noreply at phabricator.kde.org
Mon Aug 5 22:26:10 BST 2019
hein created this revision.
hein added reviewers: Frameworks, mart, leinir, apol.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
hein requested review of this revision.
REVISION SUMMARY
Kirigami has a `kirigami_package_breeze_icons` CMake macro that
KDE Frameworks apps targeting Android use to extract icons from
the Breeze theme into a folder that will get picked up by our
SDK for inclusion in the eventual .apk binary package.
Applications that bundle their own application icon that is not
included in the Breeze theme do not benefit from this, as that
macro relies on making a clone of breeze-icons.git to work from,
and as those apps install their icons into the "hicolor" theme
instead anyway, as is spec-conformant.
This e.g. means that the application icon won't show on the
Kirigami.AboutPage Qt Quick component, which is used to display
the About dialogs in Kirigami apps.
This patch makes ecm_app_icon put app icons into the same
folder, if the constraints of being on Android and being a SVG
icon are satisfied, causing the icon to be picked up into the
.apk.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22958
AFFECTED FILES
modules/ECMAddAppIcon.cmake
To: hein, #frameworks, mart, leinir, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20190805/60c23938/attachment.html>
More information about the Kde-buildsystem
mailing list