D15068: Bindings: Correct handling of sources containing utf-8

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Sep 14 13:28:47 BST 2018


bruns added a comment.


  In D15068#325752 <https://phabricator.kde.org/D15068#325752>, @bcooksley wrote:
  
  > The code itself looks fine to me - the change on line 752 is to allow handling of macOS / Windows line endings in addition to just Unix line endings I presume?
  
  
  Yes. Thats what python does by default when reading files in text mode (converting all newline variants to Unix newlines).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15068

To: bruns, #frameworks, lbeltrame
Cc: lbeltrame, bcooksley, jtamate, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20180914/d7669130/attachment.html>


More information about the Kde-buildsystem mailing list