D15070: Bindings: Support using sys paths for python install directory

[Stefan Brüns]

bruns added a comment.


  In D15070#347945 <https://phabricator.kde.org/D15070#347945>, @cgiboudeaux wrote:
  
  > In D15070#347944 <https://phabricator.kde.org/D15070#347944>, @bruns wrote:
  >
  > > So, after another week, no reason has been given not to accept this.
  > >
  > > 1. It fixes broken behavior on several platforms
  > > 2. It does not break current setups
  > > 3. It is consistent with other config variables
  >
  >
  > That's not true, you're refusing to fix the issues. Why should we invest time reviewing your changes, exactly?
  
  
  I answered this inline
  
  > - The wrong hardcoded lib/ destination wasn't fixed
  
  If I change this, it breaks the backwards compatibility. It currently is broken, and you have to opt-in in the current fixed behaviour.
  
  > - The empty 'if' is still there
  
  And I answered why it is there. Your proposals how to "fix" this leads to inconsistent behavior. Changing this in a way which keeps consistent behaviour makes the code less readable (either more nesting or longer conditions in the if statement). Policy is not there to be followed blindly.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20181024/daaf9283/attachment.html>