D16894: [ECM] use a macro to test compiler flag support

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> KDECompilerSettings.cmake:195
> +# CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 6.0.0
> +macro (KDE_CHECK_CXX_COMPILER_FLAG _RESULT _FLAG)
> +    # treat the arguments following _FLAG as a boolean expression

Why can't we just use check_cxx_compiler_flag?

> KDECompilerSettings.cmake:203
> +    if (COMPILER_OK)
> +        if(APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang")
> +            # Clang on APPLE needs verification because of Apple's

Why have a macro that only works on Apple?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system
Cc: apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20181115/08ffa0dd/attachment.html>