D13698: Improve ECMAddAppIconMacro.

Dominik Schmidt noreply at phabricator.kde.org
Fri Jun 29 15:29:00 UTC 2018


dschmidt marked 8 inline comments as done.
dschmidt added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in ECMAddAppIcon.cmake:161
> 36? It's not mentioned in the doc.

Good catch, I forgot to update this part after I fixed the resolutions in a different place.. The resolutions I copied from the original ownCloud macro were wrong in the first place, maybe because Apple changed the rules/resolutions at some point.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13698

To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20180629/f3e7c945/attachment.html>


More information about the Kde-buildsystem mailing list