D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Looks good. What's your migration plan ?
  if you don't want to bump the ECM requirements for applications looking for pulseaudio, you have to set some compatibility/deprecated vars (eg: kmix uses uppercase variables)

INLINE COMMENTS

> FindPulseAudio.cmake:109
> +
> +if(PulseAudio_FOUND AND NOT TARGET PulseAudio::PulseAudio)
> +  add_library(PulseAudio::PulseAudio UNKNOWN IMPORTED)

PulseAudio_FOUND is undefined if you add this block here.

Move it below find_package_handle_standard_args(...)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170916/5c1d88d1/attachment.html>