D8998: Add FindSeccomp to find-modules

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindSeccomp.cmake:12
> +#     The seccomp include directories
> +# ``Seccomp_LIBRARIES``
> +#     The seccomp libraries for linking

so, what about naming your variables Seccomp_LIBRARIES and Seccomp_INCLUDE_DIRS in the file ?

> FindSeccomp.cmake:24
> +#=============================================================================
> +# Copyright (c) 2017 Martin Flöser <mgraesslin at kde.org>, David Kahles <david.kahles96 at gmail.com>
> +#

One author per line

> FindSeccomp.cmake:56
> +
> +find_path(Seccomp_INCLUDE_DIR
> +    NAMES

Seccomp_INCLUDE_DIRS

> FindSeccomp.cmake:62
> +)
> +find_library(Seccomp_LIBRARY
> +    NAMES

Seccomp_LIBRARIES

> FindSeccomp.cmake:74-75
> +    REQUIRED_VARS
> +        Seccomp_LIBRARY
> +        Seccomp_INCLUDE_DIR
> +    VERSION_VAR

same thing here

> FindSeccomp.cmake:83-85
> +        IMPORTED_LOCATION "${Seccomp_LIBRARY}"
> +        INTERFACE_COMPILE_OPTIONS "${Seccomp_DEFINITIONS}"
> +        INTERFACE_INCLUDE_DIRECTORIES "${Seccomp_INCLUDE_DIR}"

and there

> FindSeccomp.cmake:89
> +
> +mark_as_advanced(Seccomp_LIBRARY Seccomp_INCLUDE_DIR)
> +

here as well

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8998

To: davidk, graesslin
Cc: cgiboudeaux, #frameworks, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20171126/1c7d29c8/attachment.html>