D8780: Try `llvm-config` to find `libclang`

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> turbov wrote in FindPythonModuleGeneration.cmake:212
> What distribution is this? Why only 3.8 and 3.9?? Why not 4.0 or 5.0???
> 
> I've just checked Ubuntu 14.04 (Clang 3.3 to 3.9 available) and 17.10 (up to 5.0 available)... installing `libclang-X.Y` (or `libclang-X.Y-devel` obviously) always bring `libclang.so` library (which is of cause a symlink to a versioned name), but it always here... Also, I've checked CentOS 7 w/ DTS7 <https://www.softwarecollections.org/en/scls/rhscl/devtoolset-7/> (Clang 4.0) -- same here...
> 
> so the question is "why to search a versioned name?" -- I don't know any distro where `libclang.so` is not available... do you?

As Shaheed explained, this was added for Ubuntu.
I've no idea what you checked but according to https://packages.ubuntu.com/artful/i386/libclang-3.9-dev/filelist Ubuntu artful will still have /usr/lib/i386-linux-gnu/libclang-3.9.so.

libclang.so is installed in /usr/lib/llvm-3.9/lib/libclang.so. Finding *this* file is possible but that means adding llvm-3.9/lib to the HINTS line rather than having "clang-3.9" on the NAMES one.

4.0 and 5.0 are also affected but I thought this review was about fixing FindPythongModuleGeneration for everyone else.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8780

To: turbov
Cc: cgiboudeaux, shaheed, #frameworks, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20171114/39118999/attachment.html>