D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In https://phabricator.kde.org/D6772#126799, @apol wrote:
  
  > What's the background for the change?
  
  
  When KDE_INSTALL_USE_QT_SYS_PATHS is explicitely set to ON but no qmake-qt5 executable found (like @rdieter reported to be possible on fedora packaging), query_qmake will only emit a warning and then return an empty string.
  Just, e.g. KDEInstallDirs code does not check for that empty string/error, but assumes a proper value to be returned when using it for estimating the Qt system paths, e.g. like this:
  
    query_qmake(qt_plugins_dir QT_INSTALL_PLUGINS)
    
    _define_absolute(QTPLUGINDIR ${qt_plugins_dir}
        "Qt plugins"
         QT_PLUGIN_INSTALL_DIR)
  
  And given there is no sane default here, but instead we expect to get the paths from qmake, these kinds of calls to query_qmake should fail hard if there no executable.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6772

To: kossebau, #frameworks, ltoscano, rdieter, apol
Cc: #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170719/dc991459/attachment.html>