D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong
Wolfgang Bauer
noreply at phabricator.kde.org
Fri Jul 14 13:35:14 UTC 2017
wbauer created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Currently the test still passes even if one of the check_translations() calls fail.
The reason is that check_translations() is a function which has its own scope, so if it sets "failed" the upper level doesn't see it.
Use the PARENT_SCOPE option when setting the variable to properly propagate the value to the upper level.
TEST PLAN
Make a change so that the test is expected to fail, e.g. modify an expected output in tests/ECMPoQmToolsTest/check.cmake.in.
make test now will correctly mark the test as failed, before the test still passed.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6701
AFFECTED FILES
tests/ECMPoQmToolsTest/check.cmake.in
To: wbauer, skelly
Cc: #frameworks, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170714/09fec032/attachment.html>
More information about the Kde-buildsystem
mailing list