cmake 3.9 breaks compiling kconfig (and dbus adaptors/interfaces)

[David Faure]

On dimanche 2 juillet 2017 23:16:56 CEST Sebastian Holtermann wrote:
> Hi David.
> 
> > another issue with cmake 3.9 seems to be the case where the header is
> > called foo_p.h rather than foo.h (as is often done for files that won't
> > get installed, in a library).
> > 
> > Example: kconfigwidgets.git fails to build, with this error:
> > 
> > CMakeFiles/KF5ConfigWidgets.dir/kcolorschememanager.cpp.o: In function
> > `KColorSchemeModel::KColorSchemeModel(QObject*)':
> > /d/kde/src/5/frameworks/kconfigwidgets/src/kcolorschememanager.cpp:39:
> > undefined reference to `vtable for KColorSchemeModel'
> > 
> > src/kcolorschememanager_p.h: class KColorSchemeModel : public
> > QAbstractListModel src/kcolorschememanager.cpp:
> > KColorSchemeModel::KColorSchemeModel(QObject *parent) (no moc include
> > anywhere, AUTOMOC used to take care of this)
> > 
> > Same problem in kxmlgui, sonnet, knewstuff...
> > 
> > Can you have a look?
> 
> This is an regression, but I think I found the problem.
> Unfortunately while removing code duplication, a for loop was exited too
> early. I'm surprised this wasn't caught by the tests.
> Could you test this branch, please:
> https://gitlab.kitware.com/sebholt/cmake/tree/autogen_p

Thanks, this fixes the build for all the modules I listed above.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5