Review Request 129900: Re-introduce the missing databases.

[Shaheed Haque]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129900/
-----------------------------------------------------------

(Updated Jan. 28, 2017, 7:36 p.m.)


Review request for Extra Cmake Modules.


Repository: extra-cmake-modules


Description
-------

This involved:

1. Restoring the ability for rules_engine.py to be run so as to generate
   it own documentation, and support for the following rule databases:

   - Unexposed
   - Typecode

2. Restoring the corresponding support in sip_generator.py.

3. Improved diagnostics by making each Rule and AbstractCompiledCodeDb
   have a useful names, and then using the results when tracing rule
   execution (and usage dumping). This should make it MUCH easier to
   debug rule-related issues.

4. Unit tests for the new functionality.


Diffs
-----

  find-modules/.gitignore PRE-CREATION 
  find-modules/Qt5Ruleset.py 2d8cfaacd1a6e15afe533bc15b6177c49441a852 
  find-modules/rules_engine.py 955a8eb69115723a5c527d5067dd0d82bb7f968c 
  find-modules/sip_generator.py ba9dd636aeb1bf7345f87e5f05bcf530f53f2e2c 
  tests/GenerateSipBindings/cpplib.h a91b54864a5d3601a37f8f788fc4f3e9bb8ba323 
  tests/GenerateSipBindings/rules_SipTest.py c570a03988e63bf6a03641fa21035ee678dcad22 
  tests/GenerateSipBindings/testscript.py e79706bcb2d337484e8ce2098eaacd95c15cae9b 

Diff: https://git.reviewboard.kde.org/r/129900/diff/


Testing (updated)
-------

1. Added a bunch of unit tests to ECM and then:

Test project .../extra-cmake-modules
      Start  1: GenerateSipBindings
 1/49 Test  #1: GenerateSipBindings ...................................   Passed   17.26 sec
      Start  2: ExecuteCoreModules
 2/49 Test  #2: ExecuteCoreModules ....................................   Passed    0.39 sec
      Start  3: ExecuteKDEModules
 3/49 Test  #3: ExecuteKDEModules .....................................   Passed    0.41 sec
      Start  4: KDEInstallDirsTest.relative_or_absolute
 4/49 Test  #4: KDEInstallDirsTest.relative_or_absolute ...............   Passed    0.40 sec
      Start  5: KDEInstallDirsTest.vars_in_sync_no_args
...

2. Verified against KGuiAddons (at cb82278f0b4da446a7859873f3e99ca64c470552).

Test project .../kguiaddons
    Start 1: appstreamtest
1/6 Test #1: appstreamtest ....................   Passed    0.02 sec
    Start 2: Py3TestKGuiAddons
2/6 Test #2: Py3TestKGuiAddons ................   Passed    0.24 sec
    Start 3: Py2TestKGuiAddons
3/6 Test #3: Py2TestKGuiAddons ................   Passed    0.23 sec
    Start 4: kwordwraptest
4/6 Test #4: kwordwraptest ....................   Passed    0.18 sec
    Start 5: kcolorutilstest
5/6 Test #5: kcolorutilstest ..................   Passed    0.53 sec

3. Reviewed against regression with bulk tools:

(From module-generator.py)
INFO: Summary: 0 processing errors for 2315 files in 170 modules

(From module-compiler.py)
ERROR: Summary: 140 processing errors for 165 modules

(Modules built)
$ find tmp2/python/ -name *.so|wc -l
25


Thanks,

Shaheed Haque

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170128/ab8a03e2/attachment-0001.html>