Review Request 129765: Handle the case of an enum with visibility attributes.
Stephen Kelly
steveire at gmail.com
Wed Jan 4 22:11:01 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129765/#review101803
-----------------------------------------------------------
Hi Shaheed,
Can you also add something to the unit test python code which asserts the (not zero) value of an enum with an attribute like this?
Thanks,
Steve.
- Stephen Kelly
On Jan. 3, 2017, 11:18 p.m., Shaheed Haque wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129765/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 11:18 p.m.)
>
>
> Review request for Extra Cmake Modules.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> The problem can be seen in the wild in, for example,
> KActivitiesStats/kactivitiesstats/cleaning.h
>
>
> Diffs
> -----
>
> find-modules/sip_generator.py 10be147711540437d38153fa8fe859bd34d7aa6c
> tests/GenerateSipBindings/cpplib.h 0d63c30ed52b5d817c233e358b1ebce7a70c8218
>
> Diff: https://git.reviewboard.kde.org/r/129765/diff/
>
>
> Testing
> -------
>
> $ make test
> Running tests...
> Test project /home/.../extra-cmake-modules
> Start 1: GenerateSipBindings
> 1/49 Test #1: GenerateSipBindings ................................... Passed 8.59 sec
> Start 2: ExecuteCoreModules
> 2/49 Test #2: ExecuteCoreModules .................................... Passed 0.46 sec
> Start 3: ExecuteKDEModules
>
>
> Thanks,
>
> Shaheed Haque
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170104/e883b85d/attachment.html>
More information about the Kde-buildsystem
mailing list