[Differential] [Commented On] D4589: EditorConfig module

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> Findeditorconfig.cmake:2
> +#
> +# Copyright (c) 2016 João Valverde <joao.valverde at tecnico.ulisboa.pt>
> +# All rights reserved.

1. Please add yourself as copyright holder.

2. Could you have a look at the comments at the very top of the other find modules in the extra-cmake-modules? There, you can find a ".rst" header that contains documentation about the find module, see e.g. libgit2 again. Could you add this documentation as well for this find module?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D4589

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #build_system, #frameworks, alexmerry
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170214/c730d29a/attachment.html>