[Differential] [Commented On] D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes.

[Stephen Kelly]

skelly added inline comments.

INLINE COMMENTS

> rules_engine.py:58
> +# Keep PyCharm happy.
> +_ = _
> +

I don't think this should be here.

> rules_engine.py:494
>                                      name                The name of the typedef.
> +                                    fn_result           Result, for a function pointer.
> +                                    decl                The declaration.

Does the docs match the code if you add this here? Why is this in this commit?

> rules_engine.py:704
>      def _get(self, item, name):
> -
> +        #
> +        # Lookup any parent-level entries.

I don't think the comments are valuable.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D4509

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: shaheed, #build_system, #frameworks, skelly
Cc: #frameworks, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170212/34ae003d/attachment.html>