Review Request 127440: Revert "ECMQtDeclareLoggingCategory: Include <QDebug> with the generated file"
Stephen Kelly
steveire at gmail.com
Sat Feb 4 11:01:09 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127440/
-----------------------------------------------------------
(Updated Feb. 4, 2017, 11:01 a.m.)
Status
------
This change has been marked as submitted.
Review request for Extra Cmake Modules, Alex Merry and Martin Klapetek.
Repository: extra-cmake-modules
Description
-------
The original review request doesn't say what concrete problem led to this being added: https://git.reviewboard.kde.org/r/126368/
QLoggingCategory has always included QDebug, so this has always been superfluous.
Diffs
-----
modules/ECMQtDeclareLoggingCategory.cmake 3f7bb79
modules/ECMQtDeclareLoggingCategory.h.in b59bc7a
Diff: https://git.reviewboard.kde.org/r/127440/diff/
Testing
-------
None.
Thanks,
Stephen Kelly
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170204/baab1c9c/attachment.html>
More information about the Kde-buildsystem
mailing list