D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes
Kevin Funk
noreply at phabricator.kde.org
Wed Dec 13 10:07:31 UTC 2017
kfunk added inline comments.
INLINE COMMENTS
> sitter wrote in KDEInstallDirs.cmake:699
> From a style perspective, I'd suggest having the prefix.sh live somewhere in the installed ECM tree and get copied, rather than maintained as a glorified heredoc in the cmake code. That's just a suggestion though.
Definitely, +1.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9299
To: apol, #frameworks, sitter
Cc: kfunk, bcooksley, ngraham, sitter, cgiboudeaux, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20171213/520f1a2b/attachment.html>
More information about the Kde-buildsystem
mailing list