D5352: Add a test for _repository_name() a function added for fetch-translations

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> CMakeLists.txt:25
> +
> +if(NOT TARGET fetch-translations AND NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../../po")
> +    message(FATAL_ERROR "should have a fetch-translations target")

`AND NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../../po"` is the wrong path, it should be CMAKE_CURRENT_SOURCE_DIR/po.

The effective source dir of the test is /tests/KDEFetchTranslations, so whether the ecm tree has a po has no impact on the target definition as it is effectively "scoped" to the /tests/KDEFetchTranslations tree.

Negative side effect of the wrongness is that the test would not pass for tarballed builds with a /po dir as the asserted conditions suddenly is true ;)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5352

To: apol, sitter, aacid
Cc: #frameworks, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170410/bf9733a9/attachment.html>