D5143: Introduce fetch-translations build command

[Harald Sitter]

sitter added a comment.


  needs a version bump in the docs now 👅
  
  beyond that LGTM

INLINE COMMENTS

> KDECMakeSettings.cmake:86
> +#
> +# Since 5.33.0
>  

5.34 now

> KDECMakeSettings.cmake:323
> +        COMMAND ruby "${CMAKE_BINARY_DIR}/releaseme/fetchpo.rb" --origin ${KDE_L10N_BRANCH} --project "${reponame}" "${CMAKE_CURRENT_SOURCE_DIR}" "${CMAKE_BINARY_DIR}/po"
> +        BYPRODUCTS "${CMAKE_BINARY_DIR}/po"
> +        DEPENDS "${CMAKE_BINARY_DIR}/releaseme"

This was only introduced in cmake 3.2. I am not sure we care or if this even would cause problems beyond a warning, but technically frameworks are 3.0 compatible (or so they claim anyway ;)). Seeing as the feature is opt-in it probably doesn't matter eitherway.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic
Cc: sitter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170405/d4778d6b/attachment.html>