Review Request 128779: Teach KDECompilerSettings about clang-cl, a mode of Clang compiler that simulates MSVC.
Gleb Popov
6yearold at gmail.com
Fri Oct 28 16:45:27 UTC 2016
> On Oct. 8, 2016, 12:09 p.m., Ben Cooksley wrote:
> > This code as it stands failed on the CI system and proceeded to break all Frameworks builds.
> > Please re-review the code and ensure that no action is taken for GCC based compilers.
>
> Gleb Popov wrote:
> I'm terribly sorry for the breakage, the change looked innocent.
>
> Could you please help me locate corresponding build log? I've got lost on Jenkins. I've found this, but it doesn't seem to be related to my commit: https://build.kde.org/job/extra-cmake-modules%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/console
>
> Ben Cooksley wrote:
> That is the affected ECM build log yes.
Does this require another "Ship it" now, or I may commit it?
- Gleb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128779/#review99843
-----------------------------------------------------------
On Oct. 12, 2016, 2:57 p.m., Gleb Popov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128779/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2016, 2:57 p.m.)
>
>
> Review request for Extra Cmake Modules and kdewin.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> By simply using `if(CMAKE_COMPILER_ID STREQUAL "Clang")` check is not enough for clang-cl, as it turns on various '-style' flags and omits MSVC's '/style' flags.
>
> With this patch i managed to compile much of KF5 up to konversation and kate.
>
> Known problems: `-std=gnu++98` flag is still appended, but i wasn't able to figure out why.
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake dfa29f7
> kde-modules/KDEFrameworkCompilerSettings.cmake 038ddc3
>
> Diff: https://git.reviewboard.kde.org/r/128779/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gleb Popov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161028/17be8138/attachment.html>
More information about the Kde-buildsystem
mailing list