Review Request 128278: Re-use tar macro from kdevplatform. To fix dependent builds reproducibility.

[Maximiliano Curia]

> On June 30, 2016, 2:50 a.m., Nicolás Alvarez wrote:
> > This brings compatibility problems with non-Linux and old Linux distros, as it will need GNU tar 1.28. I'll see if I can do something about it, maybe checking for tar's presence and using `cmake -E tar` as a fallback (printing a warning).

Currently kapptemplates has dropped the cmake file that included the reproducible tar invocation patch, in favor of using the rules in extra-cmake-modules. This causes a regression in terms of reproducible builds, as long as this patch is not accepted. :(


- Maximiliano


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128278/#review96968
-----------------------------------------------------------


On June 24, 2016, 1:27 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128278/
> -----------------------------------------------------------
> 
> (Updated June 24, 2016, 1:27 p.m.)
> 
> 
> Review request for Extra Cmake Modules, Sune Vuorela and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Cmake tar command does not allow for switches that fix umask and user/group inconsistancy which cause unreproducible builds. This patch takes the tar command used in kdevplatform that has all the required switches to make builds that use this macro reproducible.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEPackageAppTemplates.cmake c0eb8b9 
> 
> Diff: https://git.reviewboard.kde.org/r/128278/diff/
> 
> 
> Testing
> -------
> 
> Build and installed ECM and then rebuilt an affected project ( plasma-framework ) which is now reproducible.
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161024/4f666133/attachment.html>